prevent failure in flaky spec reporting when running from external PR#23845
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
toy
force-pushed
the
flaky-test-comment-for-everyone
branch
from
c7a99f1 to
4409660
Compare
toy
force-pushed
the
flaky-test-comment-for-everyone
branch
from
9d4857f to
4409660
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't find a simple way to allow
gh pr commentfor external PR and knowing about flaky specs is important for maintainers, not contributors.This fixes following error (https://github.com/opf/openproject/actions/runs/27945332159/job/82688649716?pr=23811):
Error in
downstream-ci / SaaS tests (pull_request)is not relevant, fixing not seeing error message in #23882, will fix the error itself separately